clean up and add small functionality to a python file

The buildbot master configuration file ([login to view URL]) is just a plain python file defining certain vectors; we have one for our buildmaster here that has grown considerably with time, with a lot of repeated stuff (see attachment). We want to clean it up, drawing inspiration from the one for the webkit project: [login to view URL] But we do not want to objectify all (buildsteps, factories and builders), only the buildsteps; basically there would be buildsteps such as get_source_step(reponame), compile_step(workdir), extract_step(), qmake_step(project), make_step(project), test_step(cfg_file) that wrap all the platform-dependent stuff - pick up the platform from [login to view URL] (we have linux2, win32 and darwin). The idea (for example for compile_step) is that instead of having separate linux_compile_steps, linuxclang_compile_steps, osx_compile_steps and windows_compile_steps vectors, at the end we want to enter just: compile_steps = [ compile_step("src"), compile_step("dms"), compile_step("fc"), ... ] [login to view URL](compile_steps) [login to view URL](compile_steps) [login to view URL](compile_steps) [login to view URL](compile_steps) And finally the small enhancement: add additional builbot steps information to waterfall for the test_step class, see: [login to view URL] [login to view URL] The information we want to add is the number of tests failed (that you can retrieve from the return code of [login to view URL] if positive and less than 128) and a link to the report in the form: /test_reports/buildslavehostname/[login to view URL] and a link to the logs in the form /test_logs/buildslavehostname/ Versions: the buildmaster runs on debian 7 (wheezy) so buildbot version is 0.8.6 and python version is 2.7.3. Testing: what you can do is testing with "buildbot checkconfig .". You can not test RUNNING it ("buildbot start ."), unless you have a buildbot with the very same config as ours, therefore we will take care of that. You can optionally test running it with a simple buildbot setup (i.e. only on your development environment).